Add optional pe_installer_source parameter
#261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let users specify the download URL to retrieve the PE tarball from.
To permit upgrades to download installer media from arbitrary URL
reidmv
force-pushed
the
pe_installer_source
branch
from
36d0f41 to
a5a48fd
Compare
ody
approved these changes
May 11, 2022
Contributor
Author
|
Fixed the unit test error and kicked off an upgrade test here, which has now proceeded to the point where I'm comfortable it will finish. Merging now, and preparing release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter to peadm::install and peadm::upgrade allows users to manually specify where to download the PE installer tarball from.